MNT: Refactors the code to adopt flake8 #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gui-FernandesBR
added
C.I.
|
Flake8 is really faster! It will help us quite a lot.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #631 +/- ##
========================================
Coverage 73.91% 73.92%
========================================
Files 70 70
Lines 10032 10032
========================================
+ Hits 7415 7416 +1
+ Misses 2617 2616 -1 ☔ View full report in Codecov by Sentry. |
Gui-FernandesBR
force-pushed
the
dev/adds-flake8-as-pylint-fallback
branch
from
1addd37 to
af9057b
Compare
…om/RocketPy-Team/RocketPy into dev/adds-flake8-as-pylint-fallback
7 tasks
phmbressan
approved these changes
Jul 6, 2024
Gui-FernandesBR
changed the title
Gui-FernandesBR
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
black rocketpy/ tests/) has passed locallypytest tests -m slow --runslow) have passed locallyCHANGELOG.mdhas been updated (if relevant)Current behavior
Pylint is the only linter adopted in our repo
New behavior
Flake8 is a simpler and faster linter that can be used to identify potential coding or formatting errors in a python file.
I added flake8 check to the CI right before the pylint checker.
A few errors pointed out by flake8 were not being detected by pylint, which really illustrates the importance of having at least 2 different linters running on production.
Breaking change
Additional information
ruffas well, but it sounds too "experimental" to me. Maybe a few months we can rediscuss it.make formatto runisortandblack.make lintto runflake8andpylintPlease run these commands before pushing to origin, the reviews will be much easier now.